This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Side test ab minus iefix #2131
Merged
Side test ab minus iefix #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I can also land the string separately in case there’s further issues |
|
Looks like this is passing, so I'm going to give it one more review on the test server and land it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the final commit in #2130 to fix IE stuff is what broke Travis (and it seems the current "IE is running AB tests" is in production, I want to land this branch, which is #2130 without its most recent commit, plus reduction of the AB test implemented here to 0% while the other test finishes running. This way localizers can get their hands on this prior to flipping the switch next week.
cc @Pomax