Added support for the new cookie banner on asus.com #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I propose to add support for the new cookie banner on asus.com (see the linked issue below for a screenshot and more details) by adding a rule for injecting cookies, as the new banner no longer has any cookie reject button to click.
As I said in the linked issue below, I don't know what Asus plans to do next with these banners. Will the new one replace the old one at some point, or maybe Asus will return to the old banner, or maybe everything will remain as it is (because different countries have different rules regarding the protection of personal data).
So for now, while the old banner is still in use, the newly added cookie injection support should handle both the new and old one. The mechanism for clicking the cookie reject button would remain as a fallback for the old banner until it is completely replaced by the new one (if that happens at all). Then, sometime in the future, this rule for asus.com will probably need to be revisited to clean it up and remove the opt-out click rule altogether.
Fixes #492