-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cookie injection support for the existing rule for asus.com #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the cookie rule you have provided and I can't get it to work. You test only using the cookie injector mechanism by setting cookiebanners.bannerClicking.enabled
to false. Let me know if it still works on your end and I can take another look at it
Hi, I still can't get the cookie injection to work as whenever the cookies get injected, I find there values get reset. Since there is already a working click rule, I think this issue can be closed. |
What do you mean by "values get reset"? I tested this rule again and both cookie injection and banner clicking work for me on asus.com. Nothing has changed in this regard since the last time we talked. Here's how the cookie injection works on my end: Cookie-injection-on-asus-com.mp4 |
This is what I am seeing. As the cookies are there but have no value set even after the mechanisms has run. @Trikolon Could you please check this out ? |
May I ask you to reopen this pull request for better visibility? It can always be closed again later if it turns out that nothing will come out of it. |
580ff9a
to
1eaf8ae
Compare
1eaf8ae
to
18d0166
Compare
I'm closing this in favor of PR #493, as the motives are different now and the banner is different too. |
In this pull request, I added cookie injection support for the rule that already exists for asus.com.
Resolves #336