Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cookie injection support for the existing rule for asus.com #337

Closed
wants to merge 1 commit into from

Conversation

Greg-21
Copy link
Contributor

@Greg-21 Greg-21 commented Dec 5, 2023

In this pull request, I added cookie injection support for the rule that already exists for asus.com.

Resolves #336

@Greg-21 Greg-21 requested a review from a team as a code owner December 5, 2023 10:15
Copy link
Contributor

@abhishekmadan30 abhishekmadan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the cookie rule you have provided and I can't get it to work. You test only using the cookie injector mechanism by setting cookiebanners.bannerClicking.enabled to false. Let me know if it still works on your end and I can take another look at it

@Greg-21
Copy link
Contributor Author

Greg-21 commented Dec 5, 2023

I've just tested the rule with cookiebanners.bannerClicking.enabled set to false, and everything seems to be working fine on my end. Here's a screenshot as proof:
Injected-cookies-and-no-banner

@abhishekmadan30
Copy link
Contributor

Hi, I still can't get the cookie injection to work as whenever the cookies get injected, I find there values get reset. Since there is already a working click rule, I think this issue can be closed.

@Greg-21
Copy link
Contributor Author

Greg-21 commented Dec 12, 2023

What do you mean by "values get reset"? I tested this rule again and both cookie injection and banner clicking work for me on asus.com. Nothing has changed in this regard since the last time we talked.

Here's how the cookie injection works on my end:

Cookie-injection-on-asus-com.mp4

@abhishekmadan30
Copy link
Contributor

Screenshot 2023-12-12 at 4 20 45 PM

This is what I am seeing. As the cookies are there but have no value set even after the mechanisms has run. @Trikolon Could you please check this out ?

@Greg-21
Copy link
Contributor Author

Greg-21 commented Dec 13, 2023

May I ask you to reopen this pull request for better visibility? It can always be closed again later if it turns out that nothing will come out of it.

@Greg-21 Greg-21 changed the title Enriched the rule for asus.com with cookie injection support Added cookie injection support for the existing rule for asus.com Jan 11, 2024
@Greg-21
Copy link
Contributor Author

Greg-21 commented Apr 5, 2024

I'm closing this in favor of PR #493, as the motives are different now and the banner is different too.

@Greg-21 Greg-21 closed this Apr 5, 2024
@Greg-21 Greg-21 deleted the asus-com-rule branch April 5, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie injection support could be added to the existing rule for asus.com
2 participants