Added various websites to the non-global OneTrust rules #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it possible for you to resubmit the patch without reordering the existing rules |
|
Here's an alternative commit with the current domain order preserved: link Is that format better? If so, I can always modify the commit in this pull request as well. |
Greg-21
force-pushed
the
non-global-onetrust-rules
branch
from
6cd180c to
1f4bff0
Compare
|
Could you please reformat the commit like the linked commit you had provided |
|
Yes, I will do that. |
Greg-21
force-pushed
the
non-global-onetrust-rules
branch
from
1f4bff0 to
ce0c602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose that at some point, the non-global OneTrust rules will have to go, but until then, I might as well take advantage of them and add a bunch of websites I came across while browsing the Internet.
Fixes #294, fixes #334
Resolves #154, resolves #193
Closes #71, closes #74