Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OneTrust opt-out rule #363

Closed
wants to merge 3 commits into from
Closed

Added OneTrust opt-out rule #363

wants to merge 3 commits into from

Conversation

palant
Copy link

@palant palant commented Dec 7, 2023

OneTrust banner has an opt-out button, not only opt-in. I only tested a bunch of domains on the list, but where I did opt-out now works.

@palant palant requested a review from a team as a code owner December 7, 2023 14:17
Copy link
Contributor

@abhishekmadan30 abhishekmadan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is already a onetrust rule that contains an optOut Rule, if there are any domains that you see within this list that do have an optOut option, please file a pull request to move them from this rule to the OneTrust one with an optOut option

@palant
Copy link
Author

palant commented Dec 7, 2023

Thank you, understood my mistake now. While all of these domains have an opt-out button that will dismiss the banner, most of the time it is hidden and this action will not be saved. So the next time you load a page, the banner shows up again.

Then it’s only a few domains where this opt-out button really works correctly. Moved those up.

@Trikolon
Copy link
Member

Trikolon commented Dec 7, 2023

We've removed the hiding behavior recently so that it doesn't look like we can handle a banner where we actually don't. I recommend to test rules with the latest version of Firefox Nightly.

@palant
Copy link
Author

palant commented Dec 7, 2023

I see. Yes, on Nightly the banner no longer disappers. But the five domains I moved up still work correctly.

@Greg-21
Copy link
Contributor

Greg-21 commented Dec 7, 2023

Would it be okay for you if I included your changes in my pull request (#335) that I opened a few days ago? By doing so, the maintainers of this project wouldn't have to merge yet another pull request for the same CMP.

@palant
Copy link
Author

palant commented Dec 7, 2023

Would it be okay for you if I included your changes in my pull request (#335) that I opened a few days ago?

From what I can tell, you already did. Ok, duplicate of #335 then.

@palant palant closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants