Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fun default composer run names #1611

Merged
merged 3 commits into from
Oct 24, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions llmfoundry/command_utils/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,18 +311,19 @@ def train(cfg: DictConfig) -> Trainer:
eval_gauntlet_config = train_cfg.eval_gauntlet or train_cfg.eval_gauntlet_str

# Optional parameters will be set to default values if not specified.
env_run_name: Optional[str] = os.environ.get('RUN_NAME', None)
run_name: str = (
train_cfg.run_name if train_cfg.run_name else env_run_name
) or 'llm'
run_name: Optional[
str] = train_cfg.run_name if train_cfg.run_name else os.environ.get(
'RUN_NAME',
None,
irenedea marked this conversation as resolved.
Show resolved Hide resolved
)
is_state_dict_sharded: bool = (
fsdp_config.get('state_dict_type', 'full') == 'sharded'
) if fsdp_config else False
save_latest_filename: str = train_cfg.save_latest_filename if train_cfg.save_latest_filename else 'latest-sharded-rank{rank}' if is_state_dict_sharded else 'latest-rank{rank}.pt'
save_filename: str = train_cfg.save_filename if train_cfg.save_filename else 'ep{epoch}-ba{batch}-rank{rank}.pt'

# Enable autoresume from model checkpoints if possible
is_user_set_run_name: bool = train_cfg.run_name is not None or env_run_name is not None
is_user_set_run_name: bool = train_cfg.run_name is not None or run_name is not None
autoresume_default: bool = False
if is_user_set_run_name and \
train_cfg.save_folder is not None \
irenedea marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading