Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fun default composer run names #1611

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Oct 23, 2024

Our previous default "llm" is depressingly literal, and because it does not change, it is hard to distinguish runs from the same environment.

https://github.com/mosaicml/composer/blob/main/composer/trainer/trainer.py#L549 composer generates some really fun and random run names, we should take advantage of this.

Testing

Tested on interactive by unsetting COMPOSER_RUN_NAME and RUN_NAME env vars.

created a run called 1729664919-daring-lori
image

@irenedea irenedea marked this pull request as ready for review October 23, 2024 06:32
@irenedea irenedea requested a review from a team as a code owner October 23, 2024 06:32
@irenedea irenedea requested a review from mvpatel2000 October 23, 2024 06:32
@irenedea irenedea changed the title Use fun default composer run names instead of llm Use fun default composer run names Oct 23, 2024
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mosaicml/llm-foundry/blob/c681a9c48002c5b7b1c847e264427ae6c9fbbd04/llmfoundry/command_utils/train.py#L325C68-L325C80

this variable can now be relaced with run_name is not None

env_run_name is also no longer needed and can be one-lined

llmfoundry/command_utils/train.py Outdated Show resolved Hide resolved
@irenedea irenedea requested a review from mvpatel2000 October 23, 2024 18:20
@irenedea irenedea requested a review from mvpatel2000 October 24, 2024 16:51
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love fun

llmfoundry/command_utils/train.py Show resolved Hide resolved
@irenedea irenedea merged commit b05c4ef into mosaicml:main Oct 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants