Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cross attention layers #1495

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Enable cross attention layers #1495

merged 6 commits into from
Aug 30, 2024

Conversation

gupta-abhay
Copy link
Contributor

@gupta-abhay gupta-abhay commented Aug 29, 2024 •
edited
Loading

  • enables encoder decoder models if needed
  • enables cross attention for flamingo (needed for multimodal)
  • enables different kv dim for kv projections (needed for multimodal)

@gupta-abhay gupta-abhay requested a review from a team as a code owner August 29, 2024 05:53
dakinggg
dakinggg approved these changes Aug 30, 2024
View reviewed changes
llmfoundry/models/layers/attention.py Outdated Show resolved Hide resolved
@gupta-abhay gupta-abhay merged commit d0dc82d into main Aug 30, 2024
9 checks passed
@gupta-abhay gupta-abhay mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gupta-abhay @dakinggg