Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing key_value_statest for x-attn through MPT Block #1511

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Allow passing key_value_statest for x-attn through MPT Block #1511

merged 1 commit into from
Sep 3, 2024

Conversation

gupta-abhay
Copy link
Contributor

@gupta-abhay gupta-abhay commented Sep 3, 2024 •
edited
Loading

  • Allows passing in key_value_states at the block level (MPTBlock) beyond just the attention layer
  • Follow up to this PR

@gupta-abhay gupta-abhay requested a review from a team as a code owner September 3, 2024 23:07
irenedea
irenedea approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you describe the change in the PR title and description?

@gupta-abhay gupta-abhay changed the title Follow up PR for cross attn Allow passing key_value_statest for x-attn through MPT Block Sep 3, 2024
@gupta-abhay gupta-abhay merged commit 4ab483f into main Sep 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gupta-abhay @irenedea