Enable phpcs and phpcbf checks to run from phar #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
============================================
+ Coverage 84.58% 84.62% +0.04%
- Complexity 689 693 +4
============================================
Files 74 74
Lines 2134 2140 +6
============================================
+ Hits 1805 1811 +6
Misses 329 329
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stronk7
force-pushed
the
enable_phpcs_check_from_phar
branch
3 times, most recently
from
5021e1d to
e9d55b9
Compare
We need the 2 CLI scripts and the CodeSniffer.conf file to be added to the phar, so we can "include" the scripts for execution and copy the conf file temporarily to be together with the phar (that's the way CodeSniffer expects it). Note this will reduce a little bit code-coverage but in a future PR I want to add some integration tests to cover the execution from phar, hardly can be done from unit tests.
stronk7
force-pushed
the
enable_phpcs_check_from_phar
branch
from
e9d55b9 to
4d76194
Compare
kabalin
approved these changes
Sep 15, 2023
|
Thanks, @kabalin , merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is very similar to #237 (that should be merged before this).
We need the 2 CLI scripts and the CodeSniffer.conf file to be added to the phar, so we can "include" the scripts for execution and copy the conf file temporarily to be together with the phar (that's the way CodeSniffer expects it).
Note this will reduce a little bit code-coverage but in a future PR I want to add some integration tests to cover the execution from phar, hardly can be done from unit tests.