Fix .env support when running from phar archive #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
force-pushed
the
dotenv_support_phar_execution
branch
from
84d2acf to
1eb5478
Compare
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
============================================
+ Coverage 84.58% 84.62% +0.04%
- Complexity 689 694 +5
============================================
Files 74 74
Lines 2134 2140 +6
============================================
+ Hits 1805 1811 +6
Misses 329 329
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stronk7
force-pushed
the
dotenv_support_phar_execution
branch
2 times, most recently
from
cc94e3c to
dd24266
Compare
We need the 2 CLI scripts and the CodeSniffer.conf file to be added to the phar, so we can "include" the scripts for execution and copy the conf file temporarily to be together with the phar (that's the way CodeSniffer expects it). Note this will reduce a little bit code-coverage but in a future PR I want to add some integration tests to cover the execution from phar, hardly can be done from unit tests.
With this changes, the moodle-plugin-ci execution will be able to find a .env file in the same directory that the .phar file containing it. That way install will be able to create that file and the rest of commands will access to that information via dotenv, avoiding to have to export any env variable manually for phar-based executions.
stronk7
force-pushed
the
dotenv_support_phar_execution
branch
from
dd24266 to
1bb9c4e
Compare
kabalin
previously approved these changes
Sep 15, 2023
stronk7
dismissed
kabalin’s stale review
The merge-base changed after approval.
|
Merged, thanks (I just rebased the branch after your review, @kabalin, and that somehow automatically dismissed your review). I've gone ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #238.
With this changes, the moodle-plugin-ci execution
will be able to find a .env file in the same directory that the .phar file containing it.
That way install will be able to create that file and the rest of commands will access to that information via dotenv, avoiding to have to export any env variable manually for phar-based executions.