Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump to BSON 6.2.0, make string quoting consistent MONGOSH-1452 #1708

Merged
merged 4 commits into from
Oct 30, 2023
Merged

feat: bump to BSON 6.2.0, make string quoting consistent MONGOSH-1452 #1708

merged 4 commits into from
Oct 30, 2023

Conversation

addaleax
Copy link
Contributor

No description provided.

Anemy
Anemy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! One question on possible testing place if we don't have one. I like the consistent quotes, was something that threw me off in the past.

packages/service-provider-core/src/printable-bson.ts Show resolved Hide resolved
@addaleax addaleax merged commit cbbd222 into main Oct 30, 2023
2 checks passed
@addaleax addaleax deleted the 1452-dev-bson6.2.0 branch October 30, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @Anemy