feat: bump to BSON 6.2.0, make string quoting consistent MONGOSH-1452 (…

…#1708)
mongodb-js · Oct 30, 2023 · cbbd222 · cbbd222
1 parent 84dd94a
commit cbbd222
Show file tree

Hide file tree

Showing 16 changed files with 105 additions and 98 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/browser-repl/src/components/utils/inspect.spec.ts b/packages/browser-repl/src/components/utils/inspect.spec.ts
@@ -43,7 +43,7 @@ describe('inspect', function () {
     it('inspects UUID', function () {
       expect(
         inspect(bson.Binary.createFromBase64('YWJjZGVmZ2hpa2xtbm9wcQ==', 4))
-      ).to.equal('UUID("61626364-6566-6768-696b-6c6d6e6f7071")');
+      ).to.equal("UUID('61626364-6566-6768-696b-6c6d6e6f7071')");
     });
 
     it('inspects nested ObjectId', function () {
@@ -57,7 +57,7 @@ describe('inspect', function () {
         inspect({
           p: bson.Binary.createFromBase64('YWJjZGVmZ2hpa2xtbm9wcQ==', 4),
         })
-      ).to.equal('{ p: UUID("61626364-6566-6768-696b-6c6d6e6f7071") }');
+      ).to.equal("{ p: UUID('61626364-6566-6768-696b-6c6d6e6f7071') }");
     });
 
     it('does not require BSON types to be instances of the current bson library', function () {

diff --git a/packages/browser-runtime-core/package.json b/packages/browser-runtime-core/package.json
@@ -42,7 +42,7 @@
     "@mongodb-js/prettier-config-devtools": "^1.0.1",
     "@mongodb-js/tsconfig-mongosh": "^1.0.0",
     "@mongosh/types": "0.0.0-dev.0",
-    "bson": "^6.1.0",
+    "bson": "^6.2.0",
     "depcheck": "^1.4.3",
     "eslint": "^7.25.0",
     "prettier": "^2.8.8",

diff --git a/packages/cli-repl/src/cli-repl.spec.ts b/packages/cli-repl/src/cli-repl.spec.ts
@@ -1575,7 +1575,7 @@ describe('CliRepl', function () {
           cliRepl,
           await testServer.connectionString()
         );
-        expect(output).to.match(/Inserted: ObjectId\("[a-z0-9]{24}"\)/);
+        expect(output).to.match(/Inserted: ObjectId\('[a-z0-9]{24}'\)/);
         expect(exitCode).to.equal(0);
       });
 
@@ -1596,7 +1596,7 @@ describe('CliRepl', function () {
           cliRepl,
           await testServer.connectionString()
         );
-        expect(output).to.match(/Inserted: ObjectId\("[a-z0-9]{24}"\)/);
+        expect(output).to.match(/Inserted: ObjectId\('[a-z0-9]{24}'\)/);
         expect(exitCode).to.equal(0);
       });
 
@@ -1614,7 +1614,7 @@ describe('CliRepl', function () {
 
         cliRepl = new CliRepl(cliReplOptions);
         await cliRepl.start(await testServer.connectionString(), {});
-        expect(output).to.match(/Inserted: ObjectId\("[a-z0-9]{24}"\)/);
+        expect(output).to.match(/Inserted: ObjectId\('[a-z0-9]{24}'\)/);
         expect(exitCode).to.equal(null);
 
         input.write(

diff --git a/packages/cli-repl/src/format-output.spec.ts b/packages/cli-repl/src/format-output.spec.ts
@@ -30,7 +30,7 @@ for (const colors of [false, true]) {
     context('when the result is a date', function () {
       it('returns the inspection', function () {
         expect(format({ value: new Date(1234567890000) })).to.include(
-          'ISODate("2009-02-13T23:31:30.000Z")'
+          "ISODate('2009-02-13T23:31:30.000Z')"
         );
         expect(format({ value: new Date(NaN) })).to.include('Invalid Date');
       });

diff --git a/packages/cli-repl/src/format-output.ts b/packages/cli-repl/src/format-output.ts
@@ -344,7 +344,7 @@ function dateInspect(this: Date, depth: number, options: any): string {
   if (isNaN(this.valueOf())) {
     return options.stylize('Invalid Date', 'date');
   }
-  return `ISODate("${this.toISOString()}")`;
+  return `ISODate('${this.toISOString()}')`;
 }
 
 function inspect(output: any, options: FormatOptions): any {

diff --git a/packages/cli-repl/src/mongosh-repl.spec.ts b/packages/cli-repl/src/mongosh-repl.spec.ts
@@ -274,7 +274,7 @@ describe('MongoshNodeRepl', function () {
     it('prints Date objects using the ISODate constructor variant', async function () {
       input.write('new Date(1620143373000)\n');
       await waitEval(bus);
-      expect(output).to.include('ISODate("2021-05-04T15:49:33.000Z")');
+      expect(output).to.include("ISODate('2021-05-04T15:49:33.000Z')");
     });
 
     it('handles a long series of errors', async function () {