Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add semantic classes to dom #4561

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: Add semantic classes to dom #4561

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d90b7ff
feat: Add semantic classes to dom
connoratrug Dec 12, 2024
942fedb
set the element that should recieve the attr.class in multi root comp…
connoratrug Dec 13, 2024
b01f372
Merge branch 'master' into feat/add-semantic-classes-to-dom
connoratrug Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/nuxt3-ssr/components/OrganisationCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ defineProps<{

<template>
<li
class="border lg:even:border-l-0 p-11 relative -mb-[1px]"
class="organisation-card border lg:even:border-l-0 p-11 relative -mb-[1px]"
data-component-name="name"
>
<div class="flex items-start flex-col h-full">
Expand Down
4 changes: 3 additions & 1 deletion apps/nuxt3-ssr/components/content/ContentBlockIntro.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ const submitForm = async () => {
<template v-else>
<div class="font-bold text-body-base">E-mail</div>
<a
class="text-blue-500 hover:underline"
class="contact-alt-email text-blue-500 hover:underline"
:href="`mailto:${contact}`"
>
{{ contact }}
Expand All @@ -203,6 +203,7 @@ const submitForm = async () => {

<template #footer>
<Button
class="contact-send-button"
v-if="contactMessageFilter && useEmailService"
type="primary"
size="small"
Expand All @@ -213,6 +214,7 @@ const submitForm = async () => {

<Button
v-else
class="contact-cancel-button"
type="secondary"
size="small"
label="Close"
Expand Down
11 changes: 10 additions & 1 deletion apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ const showPopulation = computed(
<template #main>
<ContentBlocks v-if="resource">
<ContentBlockIntro
:class="`${route.params.resourceType}-block-intro`"
:image="resource?.logo?.url"
:link="resource?.website as linkTarget"
:contact="resource?.contactEmail"
Expand All @@ -590,17 +591,24 @@ const showPopulation = computed(

<ContentBlockDescription
id="Description"
:class="`${route.params.resourceType}-block-description`"
title="Description"
:description="resource?.description"
/>

<ContentCohortGeneralDesign
id="GeneralDesign"
:class="`${route.params.resourceType}-block-general-design`"
title="General Design"
:resource="resource as IResources"
/>

<ContentBlock v-if="showPopulation" id="population" title="Population">
<ContentBlock
v-if="showPopulation"
id="population"
title="Population"
:class="`${route.params.resourceType}-block-population`"
>
<CatalogueItemList :items="population" />
</ContentBlock>

Expand All @@ -614,6 +622,7 @@ const showPopulation = computed(
<ContentBlockContact
v-if="peopleInvolvedSortedByRoleAndName.length > 0"
id="Contributors"
:class="`${route.params.resourceType}-block-contributors`"
title="Contributors"
:contributors="peopleInvolvedSortedByRoleAndName"
>
Expand Down
2 changes: 1 addition & 1 deletion apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ const aboutLink = `/${route.params.schema}/ssr-catalogue/${catalogueRouteParam}/
</script>

<template>
<LayoutsLandingPage>
<LayoutsLandingPage class="landing-page">
connoratrug marked this conversation as resolved.
Show resolved Hide resolved
<PageHeader class="mx-auto lg:w-7/12 text-center" :title="title">
<template v-if="scoped" v-slot:description
>Welcome to the catalogue of
Expand Down