Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add semantic classes to dom #4561

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did

Add more semantic classes to the dom elements
This enables easy selection via dom selector

This can be use to make nicer ( readable, maintainable, stabler) selectors for analytics ( or other stuff)
Not sure if we want to use '''class''' or """data-semanic-*""" for this

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Add more semantic classes to the dom elements
This enables easy selection via dom selector
@connoratrug
Copy link
Contributor Author

"should we then wrap this in a span or something?" that one option ( make this , ( and all other stuff single root ) , other option is to add $attr.class ( $attr.[prop]) to the component as described in https://vuejs.org/guide/components/attrs.html#attribute-inheritance-on-multiple-root-nodes

@mswertz mswertz marked this pull request as ready for review December 13, 2024 13:05
@connoratrug connoratrug marked this pull request as draft December 13, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants