Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warmup py cache #4463

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

chore: warmup py cache #4463

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9424d1e
chore: warmup py cache
connoratrug Nov 8, 2024
15dd16a
add numpy and use pip3
connoratrug Nov 8, 2024
2d8d4b1
warmup pip cache in azure ci
connoratrug Nov 8, 2024
17e5f65
Merge branch 'master' into chore/warm-up-pip-cache
connoratrug Nov 10, 2024
ed0dbd7
Merge branch 'master' into chore/warm-up-pip-cache
harmbrugge Nov 11, 2024
ecccc03
Merge branch 'master' into chore/warm-up-pip-cache
connoratrug Nov 13, 2024
504ba16
Merge branch 'master' into chore/warm-up-pip-cache
connoratrug Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,10 @@ jobs:
name: prepare sql test database
command: psql -h 127.0.0.1 -p 5432 -U postgres < .docker/initdb.sql

- run:
name: warm up the cache
command: pip3 install molgenis-emx2-pyclient numpy==1.23.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why numpy==1.23.4? The current version is at 2.1.3

Copy link
Contributor Author

@connoratrug connoratrug Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version used by the client i guess ?, i'll double check

yes this one:

molgenis-emx2/backend/molgenis-emx2-tasks/src/main/java/org/molgenis/emx2/tasks/TaskServiceInDatabase.java

Line 294 in 76240c8

"numpy==1.23.4", // it has a dependency :-)

maybe update the once used in the Service ? , should be done in other pr


- run:
name: run tests and push to sonar
command: |
Expand Down
3 changes: 3 additions & 0 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ steps:
- script: |
sudo apt-get update && sudo apt-get install postgresql-client python3 python3-venv -y
displayName: postgresql client python3
- script: |
sudo pip3 install molgenis-emx2-pyclient numpy==1.23.4
displayName: warmup pip cache
- script: |
psql -h localhost -p 5432 -U postgres < .docker/initdb.sql
displayName: initialize database
Expand Down
Loading