chore: warmup py cache #4463
Open
chore: warmup py cache #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yea disappointing, but not sure if this is the issue then, i think the test needs for output ( was @harmbrugge ) working on this are, is it already merged ? |
YpeZ
reviewed
Nov 27, 2024
| @@ -180,6 +180,10 @@ jobs: | |||
| name: prepare sql test database | |||
| command: psql -h 127.0.0.1 -p 5432 -U postgres < .docker/initdb.sql | |||
|
|
|||
| - run: | |||
| name: warm up the cache | |||
| command: pip3 install molgenis-emx2-pyclient numpy==1.23.4 | |||
There was a problem hiding this comment.
Why numpy==1.23.4? The current version is at 2.1.3
There was a problem hiding this comment.
the version used by the client i guess ?, i'll double check
yes this one:
maybe update the once used in the Service ? , should be done in other pr
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
how to test:
todo: