Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermo asap #99

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Thermo asap #99

merged 2 commits into from
Aug 20, 2024

Conversation

cenamiller
Copy link
Collaborator

  1. Added CostFunctionXYZ::outputAnalysis_thermo()
  2. Removed QTString library calls in favor of std::string
  3. added MODE signifier ("wind" or "thermo") to output file names in CostFunctionXYZ::outputAnalysis, CostFunctionXYZ::outputAnalysis_thermo, and CostFunctionRTZ::outputAnalysis

…signifier (wind or thermo) to CostFunctionXYZ::outputAnalysis_thermo, CostFunctionXYZ::outputAnalysis, and CostFuctionRTZ::outputAnalysis
@cenamiller cenamiller linked an issue Aug 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 2.13904% with 183 lines in your changes missing coverage. Please review.

Project coverage is 32.52%. Comparing base (2c357bf) to head (2f8b996).
Report is 7 commits behind head on thermo_asap.

Files Patch % Lines
src/CostFunctionXYZ.cpp 2.18% 179 Missing ⚠️
src/CostFunctionRTZ.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           thermo_asap      #99      +/-   ##
===============================================
- Coverage        32.84%   32.52%   -0.33%     
===============================================
  Files               51       51              
  Lines            17289    17476     +187     
===============================================
+ Hits              5679     5684       +5     
- Misses           11610    11792     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnmauff johnmauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cenamiller Thanks for the additional output routines. They look good.

@johnmauff johnmauff merged commit 2f8b996 into mmbell:thermo_asap Aug 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the output NetCDF subrouties to generate Thermo output
2 participants