Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the output NetCDF subrouties to generate Thermo output #76

Closed
johnmauff opened this issue Jul 22, 2024 · 4 comments · Fixed by #99
Closed

Modify the output NetCDF subrouties to generate Thermo output #76

johnmauff opened this issue Jul 22, 2024 · 4 comments · Fixed by #99
Assignees

Comments

@johnmauff
Copy link
Collaborator

johnmauff commented Jul 22, 2024

Several different output routines (outputAnalysis) exist in Samuari that write NetCDF files. These output routines are specific for each different type of coordinate system 'XYZ, RTZ' and are located in CostFunctionXYZ.cpp for the wind version of Samurai and 'thermo_reference/CostFunctionThermoXYZ.cpp' for the thermo version of Samurai. The Thermo version of outputAnalysis needs to be added to the common code base. For now, I recommend that a nearly duplicate method outputAnalysisTR is created. The elimination of duplicate code can performed on a separate PR.

@cenamiller
Copy link
Collaborator

See how output should be renamed: #78

@cenamiller
Copy link
Collaborator

John will describe how subroutines need to be changed

@cenamiller
Copy link
Collaborator

developed at /glade/derecho/scratch/cmille73/APAR/issue76_NC_TRoutput

Still need to do #78 and test

@cenamiller cenamiller linked a pull request Aug 19, 2024 that will close this issue
@cenamiller
Copy link
Collaborator

Kamino cloned this issue to NCAR/samurai-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants