Reduce the number of 7s floating around the code. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## thermo_asap #94 +/- ##
==============================================
Coverage ? 32.84%
==============================================
Files ? 51
Lines ? 17289
Branches ? 0
==============================================
Hits ? 5679
Misses ? 11610
Partials ? 0 ☔ View full report in Codecov by Sentry. |
cenamiller
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Thanks @johnmauff , from what I see in the code changes the magic 7s that needed to be replaced were all obMetaSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to reduce the number of occurrences of 7 that are floating around the code. In particular, in the wind version of Samurai, there are 7 variables (varDim) and also 7 pieces of meta-data associated with each observation (obMetaSize). For the thermo version of Samurai there will still be 7 pieces of meta-data associated with each observation (obMetaSize) but will only solve for 3 variables (varDim). Ideally, the number of variables could be set early on once the type of Samurai analysis being performed can be determined by checking configHash["analysis_type"] (VarDriver3D.cpp). This PR is associated with issue #87.