Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup magic 7's and other dimension issues. #87

Closed
cenamiller opened this issue Jul 31, 2024 · 6 comments · Fixed by #98
Closed

Cleanup magic 7's and other dimension issues. #87

cenamiller opened this issue Jul 31, 2024 · 6 comments · Fixed by #98
Assignees

Comments

@cenamiller
Copy link
Collaborator

There are a lot of '7's floating around the code. Sometimes refer to

  1. number of variables
  2. size of meta data
  3. indexing

Need to consolidate to global variables for 1 and 2 points

May require a little extra work to get these variables accessible throughout code?

@cenamiller
Copy link
Collaborator Author

This is a top priority because it's required for the control code to work for the 'thermo' mode

@cenamiller
Copy link
Collaborator Author

John will do a commit where the variables currently need to be set in 2 locations - Supreeth is going to try to get that down to one global location. These values should be set in the parameter file, instead of being hard coded.

Our goal is to not need to recompile between wind and thermo runs - there should be one executable that takes the mode as a parameter

@cenamiller
Copy link
Collaborator Author

John will create a feature branch with his code progress. @johnmauff

@johnmauff
Copy link
Collaborator

PR #94 was created that partially addresses this issue

@cenamiller
Copy link
Collaborator Author

Kamino cloned this issue to NCAR/samurai-dev

@cenamiller
Copy link
Collaborator Author

Closed with PR #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants