Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 (with tests) #161

Merged
merged 6 commits into from
May 16, 2017
Merged

Conversation

tysonclugg
Copy link
Contributor

@tysonclugg tysonclugg commented May 16, 2017

@matclayton

  • Drops support for Django 1.7 (not supported, conflicts with jsonfield 2.0).
  • Add support Python 3.3, 3.4, 3.5 and 3.6.
  • Also adds config for Travis CI.
  • Second class support for PyPy (tox tests pass) since Travis CI PyPy install is broken.
  • All tests passing. 🙂

Test results from Travis CI at https://travis-ci.org/tysonclugg/django-experiments:
selection_269

Test results from tox on my machine:
selection_270

@matclayton
Copy link
Member

Thanks not looked at this in depth, more than happy to drop 1.7! We currently use codeship for CI, so I'd like to get it working on there as well. I'll need to take some time and figure it out, but once thats done, I'm happy to merge/ship this out.

@tysonclugg
Copy link
Contributor Author

I tried to look at your Codeship builds, but they're not public? Travis is free for open source...

@matclayton
Copy link
Member

Great point, I have no idea how we didn't spot that! I'll try and open it up.

@tysonclugg
Copy link
Contributor Author

This PR resolves the following issues:

@matclayton matclayton merged commit d97cd26 into mixcloud:master May 16, 2017
@tysonclugg tysonclugg deleted the py3-with-tests branch May 16, 2017 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants