Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatible python3 support #157

Closed
wants to merge 1 commit into from

Conversation

Dylgar
Copy link

@Dylgar Dylgar commented Oct 26, 2016

Theses changes get the project running with python2 and python3(#143). Unfortunately I am unable to run the tests from a clean checkout/environment with python2 without any failures so cannot confirm that it works perfectly. That being said, none of the tests have started failing due to the changes.

@matclayton
Copy link
Member

Thanks for this, its hugely welcome! I'll look at getting it merged as soon as I get some time to vet it all properly.

@tysonclugg
Copy link
Contributor

@matclayton I've updated tox.ini in PR #159, with that version you may uncomment the relevant lines to enable Python 3 tests. Any chance of reviewing this and #159 and making a release later this week?

@matclayton
Copy link
Member

Sorry I'd got swept away with work :) We still use this module very actively, infact I'm working on it today. So I'll try and find time to look at this, probably Friday. We're very happy to land Python3 support, but we'll require 2.7 as well for now. We're still a python2.7 (Django 1.11) shop, so I feel much more comfortable releasing code we still have in production and under heavy use! We'll be pushing to 3.x asap though!

@tysonclugg tysonclugg mentioned this pull request May 16, 2017
@matclayton
Copy link
Member

Closing this, as the changes we're applied as part of #161 + extended to add tox coverage for Python 3

@matclayton matclayton closed this May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants