-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies vuepress theme v64 #304
Conversation
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
✅ Deploy Preview for mitre-saf-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -16,8 +16,6 @@ | |||
}, | |||
"devDependencies": { | |||
"@vuepress/bundler-vite": "2.0.0-rc.19", | |||
"@vuepress/plugin-markdown-image": "2.0.0-rc.66", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these suposed to be removed or was there a change we expected to see in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, the theme has bundled it internally and no longer needs you to install these plugins yourself. You can see that the functionality still works due to graphics still being displayed properly:
Here is the package-lock file which shows that the plugin is still installed even after I removed it from our package.json file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a chage? see question.
You should also let george know that this plugin is auto installed but just has to be enabled in the theme settings, as I think he and Dan work trying to build their own method but they could just use this. |
No description provided.