Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies vuepress theme v64 #304

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

Amndeep7
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Dec 14, 2024

Deploy Preview for mitre-saf-training ready!

Name Link
🔨 Latest commit fcc3686
🔍 Latest deploy log https://app.netlify.com/sites/mitre-saf-training/deploys/6762088cbdb3840008002709
😎 Deploy Preview https://deploy-preview-304--mitre-saf-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -16,8 +16,6 @@
},
"devDependencies": {
"@vuepress/bundler-vite": "2.0.0-rc.19",
"@vuepress/plugin-markdown-image": "2.0.0-rc.66",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these suposed to be removed or was there a change we expected to see in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the theme has bundled it internally and no longer needs you to install these plugins yourself. You can see that the functionality still works due to graphics still being displayed properly:
image

image
Here is the package-lock file which shows that the plugin is still installed even after I removed it from our package.json file.

Copy link
Member

@aaronlippold aaronlippold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a chage? see question.

@aaronlippold
Copy link
Member

You should also let george know that this plugin is auto installed but just has to be enabled in the theme settings, as I think he and Dan work trying to build their own method but they could just use this.

@aaronlippold aaronlippold merged commit c4ecce2 into main Dec 18, 2024
9 checks passed
@Amndeep7 Amndeep7 mentioned this pull request Dec 18, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants