-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delta Additional Modification #302
Conversation
Signed-off-by: George M Dias <[email protected]>
✅ Deploy Preview for mitre-saf-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: George M Dias <[email protected]>
Signed-off-by: George M Dias <[email protected]>
Signed-off-by: George M Dias <[email protected]>
Signed-off-by: George M Dias <[email protected]>
.github/workflows/deploy-docs.yml
Outdated
@@ -3,7 +3,7 @@ name: Deploy Docs | |||
on: | |||
push: | |||
branches: | |||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not have to change as PRs automatically get deploy previews
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using for testing only - for some reason the theme configuration is not working properly when switching from light to dark mode, both images are displayed (see page 7) locally it works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was told to share this with you. Upstream continues to make breaking changes. You might want to see if changing where the setting was placed fixes your issue that you're having.
Signed-off-by: George M Dias <[email protected]>
Signed-off-by: George M. Dias <[email protected]>
Signed-off-by: George M Dias <[email protected]>
Implement proposed modification reviewed by Emily on 12-Dec-2024