feat: Update proto def to pass 'buf lint' #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I imagine this will break the working communication with the dummy plugin via |
|
Ah, you're right that I'll need to update that as well. I'll amend the patch with that. |
|
Julian has some in-flight changes to the demo plugin with stuff that we'll be pulling out into our Rust plugin SDK, and I'd rather that get merged first and then rebase this on top. So this'll wait until that's ready. |
alilleybrinker
force-pushed
the
alilleybrinker/proto-lints
branch
from
3719a68 to
0d7a268
Compare
|
Resolved merge conflicts, now to get it to compile again haha |
alilleybrinker
force-pushed
the
alilleybrinker/proto-lints
branch
from
7cecaa2 to
9cdc659
Compare
|
@j-lanson ready for re-review |
j-lanson
reviewed
Aug 29, 2024
This commit modifies the protobuf definition for Hipcheck plugins to meet the expectations of 'buf lint', which checks protobuf definitions against a set of best practices. The main goal here is to make the service definition more defensive against forward-compatibility issues. This also includes updates to the code that interacts with the generated code to make sure it still compiles. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/proto-lints
branch
from
1594100 to
57cb0f0
Compare
|
@j-lanson removed boxed query stream. Ready for re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the protobuf definition for Hipcheck plugins to meet the expectations of 'buf lint', which checks protobuf definitions against a set of best practices. The main goal here is to make the service definition more defensive against forward-compatibility issues.
This also includes updates to the code that interacts with the generated code to make sure it still compiles.