feat: Update proto def to pass 'buf lint'

This commit modifies the protobuf definition for Hipcheck plugins to meet the
expectations of 'buf lint', which checks protobuf definitions against a set
of best practices. The main goal here is to make the service definition more
defensive against forward-compatibility issues.

This also includes updates to the code that interacts with the generated code
to make sure it still compiles.

Signed-off-by: Andrew Lilley Brinker <[email protected]>

.buf.yaml

@@ -0,0 +1,5 @@
+version: v2
+lint:
+  use:
+    - DEFAULT
+  rpc_allow_same_request_response: true

hipcheck/Cargo.toml

@@ -131,6 +131,7 @@ which = { version = "6.0.3", default-features = false }
 xml-rs = "0.8.20"
 xz2 = "0.1.7"
 zip = "2.1.6"
+tokio-stream = "0.1.15"
 
 [build-dependencies]
 

hipcheck/build.rs

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 fn main() -> anyhow::Result<()> {
-	tonic_build::compile_protos("proto/hipcheck.proto")?;
+	tonic_build::compile_protos("../proto/hipcheck/v1/hipcheck.proto")?;
 	Ok(())
 }

hipcheck/src/main.rs

@@ -27,7 +27,7 @@ mod util;
 mod version;
 
 pub mod hipcheck {
-	include!(concat!(env!("OUT_DIR"), "/hipcheck.rs"));
+	include!(concat!(env!("OUT_DIR"), "/hipcheck.v1.rs"));
 }
 
 use crate::analysis::report_builder::build_report;

hipcheck/src/plugin/manager.rs

@@ -1,4 +1,4 @@
-use crate::hipcheck::plugin_client::PluginClient;
+use crate::hipcheck::plugin_service_client::PluginServiceClient;
 use crate::plugin::{HcPluginClient, Plugin, PluginContext};
 use crate::{hc_error, Result, F64};
 use futures::future::join_all;
@@ -106,7 +106,7 @@ impl PluginExecutor {
 					.mul_f64(jitter_percent);
 				sleep_until(Instant::now() + sleep_duration).await;
 				if let Ok(grpc) =
-					PluginClient::connect(format!("http://127.0.0.1:{port_str}")).await
+					PluginServiceClient::connect(format!("http://127.0.0.1:{port_str}")).await
 				{
 					opt_grpc = Some(grpc);
 					break;