Adds error handling for group name length

package.json

@@ -15,10 +15,11 @@
     "test-only": "NODE_ENV=test_local pkg-test-only"
   },
   "devDependencies": {
-    "@mishguru/package": "^4.3.1",
+    "@mishguru/package": "^5.1.0",
     "nock": "^9.4.1"
   },
   "dependencies": {
+    "es6-error": "^4.1.1",
     "json-fetch": "^7.5.1",
     "node-fetch": "^2.1.2",
     "query-string": "^6.1.0",

src/errors.js

@@ -0,0 +1,18 @@
+import ExtendableError from 'es6-error'
+
+class GroupNameCharLimitExceeded extends ExtendableError {
+  constructor () {
+    super('GeniusLink group name is longer than the max character limit of 20 characters')
+  }
+}
+
+class AddLinkToGroupFailed extends ExtendableError {
+  constructor () {
+    super('Genius API could not generate a code, but still came back with 200')
+  }
+}
+
+export {
+  GroupNameCharLimitExceeded,
+  AddLinkToGroupFailed
+}

src/index.js

@@ -1,4 +1,4 @@
-/* @flow */
+// @flow
 
 import initGeniusLink from './initGeniusLink'
 import addGroup from './requests/addGroup'

src/initGeniusLink.js

@@ -1,4 +1,4 @@
-/* @flow */
+// @flow
 
 import { setApiKeys } from './request'
 

src/initGeniusLink.spec.js

@@ -1,4 +1,4 @@
-/* @flow */
+// @flow
 
 import test from 'ava'
 import nock from 'nock'

src/request.js

@@ -1,4 +1,4 @@
-/* @flow */
+// @flow
 
 import fetch, { retriers } from 'json-fetch'
 import qs from 'query-string'

src/requests/addGroup.js

@@ -1,10 +1,14 @@
-/* @flow */
+// @flow
 
 import { makeGetRequest } from '../request'
+import { GroupNameCharLimitExceeded } from '../errors'
 
 const PATH = '/v1/groups/add'
 
 const addGroup = async (name: string) => {
+  if (name.length > 20) {
+    throw new GroupNameCharLimitExceeded()
+  }
   const res = await makeGetRequest(PATH, {
     GroupName: name
   })

src/requests/addGroup.spec.js

@@ -1,7 +1,8 @@
-/* @flow */
+// @flow
 
 import test from 'ava'
 import nock from 'nock'
+import { GroupNameCharLimitExceeded } from '../errors'
 
 import addGroup from './addGroup'
 
@@ -32,3 +33,11 @@ test(`create a new tracked link`, async (t) => {
 
   t.is(newGroupId, NEW_GROUP_ID)
 })
+
+test(`GroupNameCharLimitExceeded is thrown when the group name is too long`, async (t) => {
+  const GROUP_NAME = 'hereisareallyreallylonggroupname'
+
+  const error = await t.throwsAsync(addGroup(GROUP_NAME))
+
+  t.truthy(error instanceof GroupNameCharLimitExceeded)
+})

src/requests/addLinkToGroup.js

@@ -1,6 +1,7 @@
-/* @flow */
+// @flow
 
 import { makePostRequest } from '../request'
+import { AddLinkToGroupFailed } from '../errors'
 
 const PATH = '/v1/links/add'
 
@@ -14,9 +15,7 @@ const addLinkToGroup = async (url: string, TSID: string | number) => {
   const [ linkResponse ] = res.body.LinkResponses
 
   if (linkResponse.ErrorMessage && linkResponse.ErrorMessage !== '') {
-    const error = new Error('Genius API could not generate a code, but still came back with 200')
-    error.originalMessage = linkResponse.ErrorMessage
-    throw error
+    throw new AddLinkToGroupFailed()
   }
 
   return linkResponse.NewLink.ShortUrlCode

src/requests/addLinkToGroup.spec.js

@@ -1,8 +1,8 @@
-/* @flow */
-
 import test from 'ava'
 import nock from 'nock'
 
+import { AddLinkToGroupFailed } from '../errors'
+
 import addLinkToGroup from './addLinkToGroup'
 
 test(`create a new tracked link`, async (t) => {
@@ -37,5 +37,6 @@ test('If genius replies with 200 but LinkResponses contains an error message, th
       }]
     })
 
-  await t.throws(addLinkToGroup(LINK, GROUP_ID), 'Genius API could not generate a code, but still came back with 200')
+  const error = await t.throwsAsync(addLinkToGroup(LINK, GROUP_ID))
+  t.truthy(error instanceof AddLinkToGroupFailed)
 })

src/requests/getGroupDetails.js

@@ -1,4 +1,4 @@
-/* @flow */
+// @flow
 
 import { makeGetRequest } from '../request'
 

src/requests/getGroupDetails.spec.js

@@ -1,4 +1,4 @@
-/* @flow */
+// @flow
 
 import test from 'ava'
 import nock from 'nock'

src/requests/getTotalLinkClicks.js

@@ -1,4 +1,4 @@
-/* @flow */
+// @flow
 import { pathOr } from 'ramda'
 
 import { makeGetRequest } from '../request'

src/requests/getTotalLinkClicks.spec.js

@@ -1,4 +1,4 @@
-/* @flow */
+// @flow
 
 import test from 'ava'
 import nock from 'nock'