Adds error handling for group name length #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name is more than 20 characters
src/requests/addGroup.spec.js
Outdated
| test(`GroupNameCharLimitExceeded is thrown when the group name is too long`, async (t) => { | ||
| const GROUP_NAME = 'hereisareallyreallylonggroupname' | ||
|
|
||
| const error = await t.throwsAsync(addGroup(GROUP_NAME)) |
There was a problem hiding this comment.
Suggested change
| const error = await t.throwsAsync(addGroup(GROUP_NAME)) | |
| const error = await t.throwsAsync( | |
| addGroup(GROUP_NAME), | |
| GroupNameCharLimitExceeded | |
| ) |
There was a problem hiding this comment.
You can pass an error class as the second argument to throwsAsync
src/requests/addLinkToGroup.spec.js
Outdated
| @@ -37,5 +37,6 @@ test('If genius replies with 200 but LinkResponses contains an error message, th | |||
| }] | |||
| }) | |||
|
|
|||
| await t.throws(addLinkToGroup(LINK, GROUP_ID), 'Genius API could not generate a code, but still came back with 200') | |||
| const error = await t.throwsAsync(addLinkToGroup(LINK, GROUP_ID)) | |||
| t.truthy(error instanceof AddLinkToGroupFailed) | |||
There was a problem hiding this comment.
I would suggest you use t.true here -- as instanceof returns a boolean.
But in this case, I would also suggest passing AddLinkToGroupFailed directly to throwsAsync as the second argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactored how we were handling errors in general