Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Record a map to avoid repeatedly traversing the CompactionFrom #38925

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

issue: #38811

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 2, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (aa0a87e) to head (a8766f0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38925      +/-   ##
==========================================
+ Coverage   81.13%   81.16%   +0.02%     
==========================================
  Files        1387     1387              
  Lines      196268   196289      +21     
==========================================
+ Hits       159251   159313      +62     
+ Misses      31421    31391      -30     
+ Partials     5596     5585      -11     
Components Coverage Δ
Client 79.12% <ø> (ø)
Core 69.54% <ø> (ø)
Go 83.12% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/handler.go 81.46% <100.00%> (+1.71%) ⬆️
internal/datacoord/index_service.go 93.29% <100.00%> (+<0.01%) ⬆️
internal/datacoord/server.go 73.22% <100.00%> (ø)

... and 22 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dco-passed DCO check passed. kind/bug Issues or changes related a bug sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants