Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Record a map to avoid repeatedly traversing the CompactionFrom #38926

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

issue: #38811

master pr: #38925

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 2, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (4533fc8) to head (1bdedb6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38926      +/-   ##
==========================================
- Coverage   81.05%   81.04%   -0.02%     
==========================================
  Files        1383     1383              
  Lines      195517   195537      +20     
==========================================
- Hits       158469   158464       -5     
- Misses      31471    31493      +22     
- Partials     5577     5580       +3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.45% <ø> (ø)
Go 83.02% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/handler.go 81.46% <100.00%> (+1.71%) ⬆️

... and 30 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants