Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Reduce mutex contention in datacoord meta #38904

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

  1. Using secondary index to avoid retrieving all segments at GetSegmentsChanPart.
  2. Perform batch SetAllocations to reduce the number of times the meta lock is acquired.

issue: #37630

pr: #38219

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby January 1, 2025 08:21
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 1, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 1, 2025
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (6fa096e) to head (a900127).

Files with missing lines Patch % Lines
internal/datacoord/meta.go 40.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #38904   +/-   ##
=======================================
  Coverage   81.05%   81.06%           
=======================================
  Files        1383     1383           
  Lines      195503   195513   +10     
=======================================
+ Hits       158472   158499   +27     
+ Misses      31457    31454    -3     
+ Partials     5574     5560   -14     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.45% <ø> (-0.02%) ⬇️
Go 83.05% <78.57%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/compaction_policy_clustering.go 75.48% <100.00%> (-0.12%) ⬇️
internal/datacoord/compaction_policy_single.go 61.00% <100.00%> (-0.39%) ⬇️
internal/datacoord/compaction_trigger.go 85.53% <100.00%> (+0.39%) ⬆️
internal/datacoord/segment_info.go 84.72% <100.00%> (ø)
internal/datacoord/meta.go 89.32% <40.00%> (-0.37%) ⬇️

... and 31 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants