Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix checkGeneralCapacity slowly #37976

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

bigsheeper
Copy link
Contributor

Cache the general count to speed up checkGeneralCapacity.

issue: #37630

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (1084349) to head (141c3a8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/meta_table.go 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37976      +/-   ##
==========================================
+ Coverage   81.07%   82.94%   +1.86%     
==========================================
  Files        1369     1080     -289     
  Lines      190968   165486   -25482     
==========================================
- Hits       154819   137255   -17564     
+ Misses      30659    22734    -7925     
- Partials     5490     5497       +7     
Components Coverage Δ
Client 73.67% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.19% <94.73%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/rootcoord/constrant.go 100.00% <100.00%> (ø)
internal/rootcoord/create_collection_task.go 90.31% <100.00%> (ø)
internal/rootcoord/create_partition_task.go 91.39% <100.00%> (ø)
internal/rootcoord/meta_table.go 82.82% <92.30%> (+0.10%) ⬆️

... and 308 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

czs007 pushed a commit that referenced this pull request Nov 25, 2024
Cache the general count to speed up checkGeneralCapacity.

issue: #37630

pr: #37976

Signed-off-by: bigsheeper <[email protected]>
Copy link
Contributor

mergify bot commented Nov 25, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 28, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 28, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 29, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Dec 1, 2024

rerun go-sdk

@czs007
Copy link
Collaborator

czs007 commented Dec 1, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 1, 2024
@sre-ci-robot sre-ci-robot merged commit 7fb0c28 into milvus-io:master Dec 1, 2024
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 5, 2024
Cache the general count to speed up checkGeneralCapacity.

issue: #37630

pr: #37976

---------

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants