Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix checkGeneralCapacity slowly #38074

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

bigsheeper
Copy link
Contributor

Cache the general count to speed up checkGeneralCapacity.

issue: #37630

pr: #37976

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 28, 2024
@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo November 28, 2024 09:16
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 28, 2024
@bigsheeper bigsheeper added this to the 2.4.18 milestone Dec 2, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 2, 2024

/approve

@czs007
Copy link
Collaborator

czs007 commented Dec 2, 2024

/approve
/lgtm

@sre-ci-robot sre-ci-robot removed the lgtm label Dec 3, 2024
Signed-off-by: bigsheeper <[email protected]>
Copy link
Contributor

mergify bot commented Dec 4, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper bigsheeper force-pushed the 2411-check-general-2.4 branch from c24afbd to a53b330 Compare December 4, 2024 13:17
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.25%. Comparing base (bd08b3b) to head (a53b330).
Report is 6 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/meta_table.go 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38074       +/-   ##
===========================================
+ Coverage   64.28%   72.25%    +7.97%     
===========================================
  Files         268     1074      +806     
  Lines       26479   168107   +141628     
===========================================
+ Hits        17021   121467   +104446     
- Misses       9458    42198    +32740     
- Partials        0     4442     +4442     
Files with missing lines Coverage Δ
internal/rootcoord/constrant.go 100.00% <100.00%> (ø)
internal/rootcoord/create_collection_task.go 94.40% <100.00%> (ø)
internal/rootcoord/create_partition_task.go 100.00% <100.00%> (ø)
internal/rootcoord/meta_table.go 84.04% <92.30%> (ø)

... and 1001 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Dec 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Dec 5, 2024
@sre-ci-robot sre-ci-robot merged commit 1f8299f into milvus-io:2.4 Dec 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants