-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.4] Fix checkGeneralCapacity slowly #38074
Conversation
Signed-off-by: bigsheeper <[email protected]>
/approve |
/approve |
…heck-general-2.4
Signed-off-by: bigsheeper <[email protected]>
@bigsheeper E2e jenkins job failed, comment |
Signed-off-by: bigsheeper <[email protected]>
c24afbd
to
a53b330
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #38074 +/- ##
===========================================
+ Coverage 64.28% 72.25% +7.97%
===========================================
Files 268 1074 +806
Lines 26479 168107 +141628
===========================================
+ Hits 17021 121467 +104446
- Misses 9458 42198 +32740
- Partials 0 4442 +4442
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cache the general count to speed up checkGeneralCapacity.
issue: #37630
pr: #37976