Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Remove unnecessary segment clone updating dist #37797

Merged
merged 1 commit into from
Nov 20, 2024
Merged

enhance: Remove unnecessary segment clone updating dist #37797

merged 1 commit into from
Nov 20, 2024

Conversation

congqixia
Copy link
Contributor

Related to #37630

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 19, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (dae4160) to head (1aa419c).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37797      +/-   ##
==========================================
- Coverage   81.03%   80.99%   -0.04%     
==========================================
  Files        1357     1357              
  Lines      190017   190017              
==========================================
- Hits       153977   153909      -68     
- Misses      30589    30642      +53     
- Partials     5451     5466      +15
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.88% <ø> (ø)
Go 83.16% <100.00%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
internal/querycoordv2/dist/dist_handler.go 95.96% <100.00%> (ø)

... and 35 files with indirect coverage changes

---- 🚨 Try these New Features:

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 19, 2024
@sunby
Copy link
Contributor

sunby commented Nov 20, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit b8d31eb into milvus-io:master Nov 20, 2024
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 20, 2024
@congqixia
enhance: Remove unnecessary segment clone updating dist (milvus-io#37797
f62a9c2 
)

Related to milvus-io#37630

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Nov 20, 2024
Merged
@congqixia congqixia added the 10kcp PR related to 10k collection partitions Project label Nov 20, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 20, 2024
@congqixia
enhance: [2.4] Remove unnecessary segment clone updating dist (#37797) (
28adfe4 
#37833)

Cherry-pick from master
pr: #37797
Related to #37630

Signed-off-by: Congqi Xia <[email protected]>
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
@congqixia @JsDove
enhance: Remove unnecessary segment clone updating dist (milvus-io#37797
f66ca1b 
)

Related to milvus-io#37630

Signed-off-by: Congqi Xia <[email protected]>
@bigsheeper bigsheeper mentioned this pull request Dec 27, 2024
Open
40 tasks
@bigsheeper bigsheeper mentioned this pull request Jan 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunby sunby Awaiting requested review from sunby

@weiliu1031 weiliu1031 Awaiting requested review from weiliu1031

Assignees

@sunby sunby

Labels
10kcp PR related to 10k collection partitions Project approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @sunby