Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Provide secondary index critria when filter leaderview #37777

Merged

Conversation

congqixia
Copy link
Contributor

Related to #37630

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 18, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia changed the title enhance: Provide secondary index crieria when filter leaderview enhance: Provide secondary index critria when filter leaderview Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.67%. Comparing base (226fe90) to head (cb40a67).
Report is 24 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37777       +/-   ##
===========================================
+ Coverage   68.85%   80.67%   +11.82%     
===========================================
  Files         290     1358     +1068     
  Lines       25496   191103   +165607     
===========================================
+ Hits        17554   154172   +136618     
- Misses       7942    31493    +23551     
- Partials        0     5438     +5438     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.85% <ø> (ø)
Go 83.19% <100.00%> (∅)
Files with missing lines Coverage Δ
...rnal/querycoordv2/observers/collection_observer.go 86.63% <100.00%> (ø)
internal/querycoordv2/task/action.go 92.25% <100.00%> (ø)
internal/querycoordv2/task/scheduler.go 88.65% <100.00%> (ø)

... and 1065 files with indirect coverage changes

---- 🚨 Try these New Features:

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 19, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 6d86b90 into milvus-io:master Nov 19, 2024
20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 19, 2024
@congqixia congqixia added the 10kcp PR related to 10k collection partitions Project label Nov 20, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 21, 2024
#37777) (#37802)

Cherry-pick from master
pr: #37777 
Related to #37630

---------

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants