Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add 3 builtin roles #28961

Merged
merged 1 commit into from
Dec 18, 2023

enhance: support user-defined builtin roles

30d1127
Select commit
Loading
Failed to load commit list.
Merged

enhance: add 3 builtin roles #28961

enhance: support user-defined builtin roles
30d1127
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2023 in 0s

82.04% (target 77.00%)

View this Pull Request on Codecov

82.04% (target 77.00%)

Details

Codecov Report

Merging #28961 (30d1127) into master (3f7d636) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 86.36%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #28961    +/-   ##
========================================
  Coverage   82.04%   82.04%            
========================================
  Files         862      863     +1     
  Lines      122394   122502   +108     
========================================
+ Hits       100420   100509    +89     
- Misses      18642    18660    +18     
- Partials     3332     3333     +1     
Files Coverage Δ
internal/proxy/privilege_interceptor.go 76.72% <100.00%> (ø)
pkg/util/constant.go 82.85% <100.00%> (+3.54%) ⬆️
pkg/util/funcutil/func.go 88.49% <100.00%> (+1.15%) ⬆️
pkg/util/paramtable/component_param.go 98.18% <100.00%> (+<0.01%) ⬆️
pkg/util/paramtable/param_item.go 89.18% <100.00%> (+0.19%) ⬆️
pkg/util/paramtable/role_param.go 100.00% <100.00%> (ø)
internal/rootcoord/root_coord.go 90.22% <91.89%> (+0.02%) ⬆️
internal/distributed/proxy/service.go 81.72% <0.00%> (-0.66%) ⬇️
internal/proxy/impl.go 86.27% <14.28%> (-0.12%) ⬇️

... and 16 files with indirect coverage changes