Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D4koon.WhatsappTray version 1.9.0.0 #82559

Closed
wants to merge 1 commit into from
Closed

D4koon.WhatsappTray version 1.9.0.0 #82559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions manifests/d/D4koon/WhatsappTray/1.9.0.0/D4koon.WhatsappTray.installer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Created using wingetcreate 1.1.2.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.2.0.schema.json

PackageIdentifier: D4koon.WhatsappTray
PackageVersion: 1.9.0.0
Installers:
- Architecture: x64
InstallerType: inno
InstallerUrl: https://github.com/D4koon/WhatsappTray/releases/download/v1.9.0/WhatsappTrayV1.9.0.0.exe
InstallerSha256: 6535FA20F12FD21C0ABD104E5594D4F0AE82528D4274D3470D9C1FBB3C403A18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerSha256: 6535FA20F12FD21C0ABD104E5594D4F0AE82528D4274D3470D9C1FBB3C403A18
InstallerSha256: 6535FA20F12FD21C0ABD104E5594D4F0AE82528D4274D3470D9C1FBB3C403A18
ProductCode: "{1237D679-445B-4101-B7EC-B5081C5FA4A3}_is1"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we should add the ProductCode field? Where do you get this ID? And why "_is1"?
There is not in manifest of other apps. For example: https://github.com/microsoft/winget-pkgs/blob/master/manifests/w/WhatsApp/WhatsApp/2.2236.10/WhatsApp.WhatsApp.installer.yaml

I created this commit with the wingetcreate util. And if this field is obligated, than it's a bug in the wingetcreate.

Copy link
Contributor

@ItzLevvie ItzLevvie Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we should add the ProductCode field?

It's required for this package because the developer didn't add the publisher for this application.

It's used so that WinGet can properly map the application to winget list and make winget upgrade work.

You can take a look at https://github.com/microsoft/winget-pkgs/blob/master/doc/manifest/schema/1.2.0/installer.md

winget-create already does the ProductCode automatically for MSI installers, but for EXE installers, there's really no easy way other than to install the application to a virtual machine (VM) and monitoring the Windows Registry.

Where do you get this ID?

It's taken from the Windows Registry.

You can take a look at https://github.com/ItzLevvie/winget-pkgs-validate-and-install/blob/f4db043f8c11953c96c7976b90ec486f992933f6/Community%20Moderators%20-%202022-10-02%20-%20development.ps1#L185-L200

And why "_is1"?

That's just what Inno Setup does — which is what this application is wrapped around with to create an installer.

ManifestType: installer
ManifestVersion: 1.2.0

13 changes: 13 additions & 0 deletions manifests/d/D4koon/WhatsappTray/1.9.0.0/D4koon.WhatsappTray.locale.en-US.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Created using wingetcreate 1.1.2.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.2.0.schema.json

PackageIdentifier: D4koon.WhatsappTray
PackageVersion: 1.9.0.0
PackageLocale: en-US
Publisher: D4koon
PackageName: WhatsappTray
License: GNU General Public License v3.0
ShortDescription: Extension for the Whatsapp Desktop Client, that enables minimize-to-tray and close-to-tray functionality.
ManifestType: defaultLocale
ManifestVersion: 1.2.0

9 changes: 9 additions & 0 deletions manifests/d/D4koon/WhatsappTray/1.9.0.0/D4koon.WhatsappTray.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Created using wingetcreate 1.1.2.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.2.0.schema.json

PackageIdentifier: D4koon.WhatsappTray
PackageVersion: 1.9.0.0
DefaultLocale: en-US
ManifestType: version
ManifestVersion: 1.2.0