D4koon.WhatsappTray version 1.9.0.0

[medvedev125]

• Have you signed the Contributor License Agreement?
• Have you checked that there aren't other open pull requests for the same manifest update/change?
• Have you validated your manifest locally with winget validate --manifest <path>?
• Have you tested your manifest locally with winget install --manifest <path>?
• Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

---

Microsoft Reviewers: Open in CodeFlow

[wingetbot]

   

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[medvedev125]

@microsoft-github-policy-service agree

[medvedev125]

There is a related feature request in WhatsappTray project: D4koon/WhatsappTray#145

[ghost]

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

medvedev125,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

[ItzLevvie]

Suggested change

	InstallerSha256: 6535FA20F12FD21C0ABD104E5594D4F0AE82528D4274D3470D9C1FBB3C403A18
	InstallerSha256: 6535FA20F12FD21C0ABD104E5594D4F0AE82528D4274D3470D9C1FBB3C403A18
	ProductCode: "{1237D679-445B-4101-B7EC-B5081C5FA4A3}_is1"

[medvedev125]

Why we should add the ProductCode field? Where do you get this ID? And why "_is1"?
There is not in manifest of other apps. For example: https://github.com/microsoft/winget-pkgs/blob/master/manifests/w/WhatsApp/WhatsApp/2.2236.10/WhatsApp.WhatsApp.installer.yaml

I created this commit with the wingetcreate util. And if this field is obligated, than it's a bug in the wingetcreate.

[ItzLevvie]

Why we should add the ProductCode field?

It's required for this package because the developer didn't add the publisher for this application.

It's used so that WinGet can properly map the application to winget list and make winget upgrade work.

You can take a look at https://github.com/microsoft/winget-pkgs/blob/master/doc/manifest/schema/1.2.0/installer.md

winget-create already does the ProductCode automatically for MSI installers, but for EXE installers, there's really no easy way other than to install the application to a virtual machine (VM) and monitoring the Windows Registry.

Where do you get this ID?

It's taken from the Windows Registry.

You can take a look at https://github.com/ItzLevvie/winget-pkgs-validate-and-install/blob/f4db043f8c11953c96c7976b90ec486f992933f6/Community%20Moderators%20-%202022-10-02%20-%20development.ps1#L185-L200

And why "_is1"?

That's just what Inno Setup does — which is what this application is wrapped around with to create an installer.

[ghost]

Hello @medvedev125,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

[ItzLevvie]

Please see #82559 (comment)

[ghost]

Hello @medvedev125,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

[ItzLevvie]

Close with reason: Replaced by PR 82817 to avoid having the pull request be stale;