Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in 10.0.0 #139

Merged
merged 8 commits into from
Apr 28, 2021
Merged

Fix bugs in 10.0.0 #139

merged 8 commits into from
Apr 28, 2021

Conversation

spaceisfun
Copy link
Member

@spaceisfun spaceisfun commented Apr 26, 2021

Fixes Bug 32803715: [Watson Failure] caused by CLR_EXCEPTION_System.NullReferenceException_80004003_Microsoft.FactoryOrchestrator.Service.dll!Microsoft.FactoryOrchestrator.Service.FOService.Dispose

Fixes backwards check for DisableContainerSupport

Fixes #113 - ResetService is buggy

Fixes #135 - Support /etc/FactoryOrchestrator/appsettings.json

Fixes #111 - WDP doesn't work on Desktop

Related to #140 - Implements the workaround, but will keep the issue open until an official .NET fix is made

@spaceisfun spaceisfun added the bug Something isn't working label Apr 26, 2021
@spaceisfun spaceisfun self-assigned this Apr 26, 2021
@spaceisfun spaceisfun requested a review from a team April 26, 2021 21:44
@spaceisfun spaceisfun changed the title Check if _ipcHost is NULL before disposing Fix bugs in 10.0.0 Apr 27, 2021
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 27, 2021
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 27, 2021
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 27, 2021
@spaceisfun
Copy link
Member Author

/azp run

@microsoft microsoft deleted a comment from azure-pipelines bot Apr 27, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@spaceisfun
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@spaceisfun
Copy link
Member Author

completing, as Neil is MS FTE but github is propagating his organization update sloowly

@spaceisfun spaceisfun merged commit 6db51c2 into microsoft:main Apr 28, 2021
@spaceisfun spaceisfun deleted the dontdisposenull branch May 4, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants