-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in 10.0.0 #139
Merged
Merged
Fix bugs in 10.0.0 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceisfun
changed the title
Check if _ipcHost is NULL before disposing
Fix bugs in 10.0.0
Apr 27, 2021
spaceisfun
force-pushed
the
dontdisposenull
branch
from
April 27, 2021 01:21
79993f3
to
9f3ef9e
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
NeilSandlin
approved these changes
Apr 27, 2021
completing, as Neil is MS FTE but github is propagating his organization update sloowly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Bug 32803715: [Watson Failure] caused by CLR_EXCEPTION_System.NullReferenceException_80004003_Microsoft.FactoryOrchestrator.Service.dll!Microsoft.FactoryOrchestrator.Service.FOService.Dispose
Fixes backwards check for DisableContainerSupport
Fixes #113 - ResetService is buggy
Fixes #135 - Support /etc/FactoryOrchestrator/appsettings.json
Fixes #111 - WDP doesn't work on Desktop
Related to #140 - Implements the workaround, but will keep the issue open until an official .NET fix is made