Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Windows service workaround #140

Open
spaceisfun opened this issue Apr 27, 2021 · 1 comment
Open

Remove Windows service workaround #140

spaceisfun opened this issue Apr 27, 2021 · 1 comment
Labels
QOL Quality-of-life / code clean-up

Comments

@spaceisfun
Copy link
Member

Issue is due to dotnet/runtime#50020

Workaround is documented in issue above, but requires a fork of behavior between Windows Service and Windows applications (likely by checking for an extra argument passed in to the service mode)
@spaceisfun spaceisfun added the bug Something isn't working label Apr 27, 2021
@spaceisfun spaceisfun changed the title Service doesn't start in Windows Containers Service doesn't start in Windows containers Apr 27, 2021
@spaceisfun spaceisfun mentioned this issue Apr 27, 2021
Merged
spaceisfun added a commit that referenced this issue Apr 28, 2021
@spaceisfun
Merge pull request #139 from spaceisfun/dontdisposenull
6db51c2 
Fixes Bug 32803715: [Watson Failure] caused by CLR_EXCEPTION_System.NullReferenceException_80004003_Microsoft.FactoryOrchestrator.Service.dll!Microsoft.FactoryOrchestrator.Service.FOService.Dispose

Fixes backwards check for DisableContainerSupport

Fixes #113 - ResetService is buggy

Fixes #135 - Support /etc/FactoryOrchestrator/appsettings.json

Fixes #111 - WDP doesn't work on Desktop

Related to #140 - Implements the workaround, but will keep the issue open until an official .NET fix is made
@spaceisfun
Copy link
Member Author

spaceisfun commented Apr 28, 2021 •
edited
Loading

Workaround is now implemented in #139, commit 51c113e. This issue tracks reverting it once there is an official fix.

@spaceisfun spaceisfun changed the title Service doesn't start in Windows containers Remove Windows service workaround Apr 28, 2021
@spaceisfun spaceisfun added QOL Quality-of-life / code clean-up and removed bug Something isn't working labels May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QOL Quality-of-life / code clean-up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spaceisfun