Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py bash cmd generation to correctly extract git info #6762

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix setup.py bash cmd generation to correctly extract git info #6762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46d7d0d
fix setup.py bash cmd generation to correctly extract git info
nelyahu Nov 19, 2024
f4f1f94
Merge branch 'master' into patch-1
loadams Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@ def op_enabled(op_name):
print(f'Install Ops={install_ops}')

# Write out version/git info.
git_hash_cmd = shlex.split("bash -c git rev-parse --short HEAD")
git_branch_cmd = shlex.split("bash -c git rev-parse --abbrev-ref HEAD")
git_hash_cmd = shlex.split("bash -c \"git rev-parse --short HEAD\"")
git_branch_cmd = shlex.split("bash -c \"git rev-parse --abbrev-ref HEAD\"")
if command_exists('git') and not is_env_set('DS_BUILD_STRING'):
try:
result = subprocess.check_output(git_hash_cmd)
Expand Down