Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py bash cmd generation to correctly extract git info #6762

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

nelyahu
Copy link
Contributor

@nelyahu nelyahu commented Nov 19, 2024

No description provided.

@loadams
Copy link
Contributor

loadams commented Nov 19, 2024

Thanks @nelyahu!

Leaving here as a quick explainer for others, here is a sample ds_report before and after this change

Before:

DeepSpeed general environment info:
torch install path ............... ['/home/deepspeed/test/trans-venv/lib/python3.12/site-packages/torch']
torch version .................... 2.3.0+cu121
deepspeed install path ........... ['/home/deepspeed/test/trans-venv/lib/python3.12/site-packages/deepspeed']
deepspeed info ................... 0.15.5+unknown, unknown, unknown
torch cuda version ............... 12.1
torch hip version ................ None
nvcc version ..................... 12.0
deepspeed wheel compiled w. ...... torch 0.0, cuda 0.0
shared memory (/dev/shm) size .... 125.77 GB

After:

DeepSpeed general environment info:
torch install path ............... ['/home/deepspeed/test/trans-venv/lib/python3.12/site-packages/torch']
torch version .................... 2.3.0+cu121
deepspeed install path ........... ['/home/deepspeed/test/trans-venv/lib/python3.12/site-packages/deepspeed']
deepspeed info ................... 0.15.5+46d7d0d1, 46d7d0d1, patch-1
torch cuda version ............... 12.1
torch hip version ................ None
nvcc version ..................... 12.0
deepspeed wheel compiled w. ...... torch 0.0, cuda 0.0
shared memory (/dev/shm) size .... 125.77 GB

@loadams loadams changed the title fix setup.py bash cmd generation to correctly extract git info Fix setup.py bash cmd generation to correctly extract git info Nov 19, 2024
@loadams loadams enabled auto-merge November 19, 2024 16:38
@loadams loadams added this pull request to the merge queue Nov 19, 2024
@loadams loadams removed this pull request from the merge queue due to a manual request Nov 19, 2024
@loadams loadams merged commit 065398d into microsoft:master Nov 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants