Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add worker related doms #1147

Merged
merged 4 commits into from
Aug 11, 2024
Merged

feat: add worker related doms #1147

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5719ac5
feat: add worker related doms
tonyfettes Jun 16, 2024
5fad45e
add WorkerGlobalScopes
tonyfettes Jul 14, 2024
87fa74e
fix: remove windowProxy
tonyfettes Aug 5, 2024
62f307f
Update jscomp/others/dom.ml
anmonteiro Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions jscomp/others/dom.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,21 @@ type cssStyleSheet
(* events (early) *)
type 'a eventTarget_like
type eventTarget = _baseClass eventTarget_like
type _messagePort
type messagePort = _messagePort eventTarget_like
type _serviceWorker
type serviceWorker = _serviceWorker eventTarget_like
type _worker
type worker = _worker eventTarget_like
type 'a _workerGlobalScope
type 'a workerGlobalScope_like = 'a _workerGlobalScope eventTarget_like
type workerGlobalScope = _baseClass workerGlobalScope_like
type _dedicatedWorkerGlobalScope
type dedicatedWorkerGlobalScope = _dedicatedWorkerGlobalScope workerGlobalScope_like
type _serviceWorkerGlobalScope
type serviceWorkerGlobalScope = _serviceWorkerGlobalScope workerGlobalScope_like
type _sharedWorkerGlobalScope
type sharedWorkerGlobalScope = _sharedWorkerGlobalScope workerGlobalScope_like
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmonteiro Hi, I add these types since your last review. Could you please take a look at it?

anmonteiro marked this conversation as resolved.
Show resolved Hide resolved

(* nodes *)
type 'a _node
Expand Down Expand Up @@ -236,6 +251,8 @@ type _inputEvent
type inputEvent = _inputEvent uiEvent_like
type _keyboardEvent
type keyboardEvent = _keyboardEvent uiEvent_like
type _messageEvent
type messageEvent = _messageEvent event_like
type 'a _mouseEvent
type 'a mouseEvent_like = 'a _mouseEvent uiEvent_like
type mouseEvent = _baseClass mouseEvent_like
Expand Down Expand Up @@ -291,5 +308,6 @@ type svgPoint

(* special *)
type eventPointerId
type messageChannel

module Storage = Dom_storage