feat: add worker related doms #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Jun 30, 2024
jscomp/others/dom.ml
Outdated
| @@ -203,6 +209,7 @@ type _htmlVideoElement | |||
| type htmlVideoElement = _htmlVideoElement htmlElement_like | |||
| type location | |||
| type window | |||
| type windowProxy | |||
There was a problem hiding this comment.
why do you need windowProxy? According to MDN it's only available in a "browsing context"
There was a problem hiding this comment.
I was reading the MDN page of MessageEvent.source, and it seems that the source can be one of a WindowProxy, MessagePort or a ServiceWorker, so I added it.
After reading the page you linked above, I think it might be totally fine if we use window for all windowproxy...
anmonteiro
approved these changes
Jun 30, 2024
tonyfettes
commented
Aug 5, 2024
jscomp/others/dom.ml
Outdated
Comment on lines
23
to
31
| type 'a _workerGlobalScope | ||
| type 'a workerGlobalScope_like = 'a _workerGlobalScope eventTarget_like | ||
| type workerGlobalScope = _baseClass workerGlobalScope_like | ||
| type _dedicatedWorkerGlobalScope | ||
| type dedicatedWorkerGlobalScope = _dedicatedWorkerGlobalScope workerGlobalScope_like | ||
| type _serviceWorkerGlobalScope | ||
| type serviceWorkerGlobalScope = _serviceWorkerGlobalScope workerGlobalScope_like | ||
| type _sharedWorkerGlobalScope | ||
| type sharedWorkerGlobalScope = _sharedWorkerGlobalScope workerGlobalScope_like |
There was a problem hiding this comment.
@anmonteiro Hi, I add these types since your last review. Could you please take a look at it?
anmonteiro
reviewed
Aug 11, 2024
anmonteiro
added a commit
that referenced
this pull request
Aug 11, 2024
anmonteiro
added a commit
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add type definition needed for web worker.
Issue in melange-webapi
Related PR in melange-webapi