Always upload SARIF in PR (onnx#5486)

I realized the SARIF file wasn’t uploaded without always() Use `i` to toggle comment display if needed. Signed-off-by: Justin Chu <[email protected]>
meilofveeningen-rl · Aug 9, 2023 · 6deac42 · 6deac42
1 parent 2ae09c2
commit 6deac42
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -94,8 +94,9 @@ jobs:
         run: |
           python -m lintrunner_adapters to-sarif lint.json lintrunner.sarif
       - name: Upload SARIF file
-        # Do not display on drafts to make reviewing easier
-        if: github.event.pull_request.draft == false
+        # Use always() to always upload SARIF even if lintrunner returns with error code
+        # To toggle linter comments in the files page, press `i` on the keyboard
+        if: always()
         continue-on-error: true
         uses: github/codeql-action/upload-sarif@cdcdbb579706841c47f7063dda365e292e5cad7a # v2.13.4
         with: