Fix typo in "LayerNormalization" docs (onnx#5351)

### Description Fix typo in "LayerNormalization" node's description. Now it is said that attribute "axis" can be equal to "rank(X)", which has no sense. If you look in [tests implementation](https://github.com/onnx/onnx/blob/main/onnx/backend/test/case/node/layernormalization.py#L13-L58), you will see that it will produce tensor of zeroes. And [current tests list](https://github.com/onnx/onnx/tree/main/onnx/backend/test/data/node) doesn't include such case. Based on these facts, i assume it is just a typo. ### Motivation and Context It is a very confusing typo. Me and collegues spent some time trying to figure out, what tensor this case should produce. --------- Signed-off-by: Rail <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: G. Ramalingam <[email protected]> Co-authored-by: Chun-Wei Chen <[email protected]> Co-authored-by: Justin Chu <[email protected]>
meilofveeningen-rl · Aug 9, 2023 · 2ae09c2 · 2ae09c2
1 parent c2f534f
commit 2ae09c2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docs/Changelog.md b/docs/Changelog.md
@@ -21029,7 +21029,7 @@ This version of the operator has been available since version 17 of the default
 
 <dl>
 <dt><tt>axis</tt> : int (default is -1)</dt>
-<dd>The first normalization dimension. If rank(X) is r, axis' allowed range is [-r, r]. Negative value means counting dimensions from the back.</dd>
+<dd>The first normalization dimension. If rank(X) is r, axis' allowed range is [-r, r). Negative value means counting dimensions from the back.</dd>
 <dt><tt>epsilon</tt> : float (default is 1e-05)</dt>
 <dd>The epsilon value to use to avoid division by zero.</dd>
 <dt><tt>stash_type</tt> : int (default is 1)</dt>

diff --git a/docs/Operators.md b/docs/Operators.md
@@ -12782,7 +12782,7 @@ This version of the operator has been available since version 17 of the default
 
 <dl>
 <dt><tt>axis</tt> : int (default is -1)</dt>
-<dd>The first normalization dimension. If rank(X) is r, axis' allowed range is [-r, r]. Negative value means counting dimensions from the back.</dd>
+<dd>The first normalization dimension. If rank(X) is r, axis' allowed range is [-r, r). Negative value means counting dimensions from the back.</dd>
 <dt><tt>epsilon</tt> : float (default is 1e-05)</dt>
 <dd>The epsilon value to use to avoid division by zero.</dd>
 <dt><tt>stash_type</tt> : int (default is 1)</dt>

diff --git a/onnx/defs/nn/defs.cc b/onnx/defs/nn/defs.cc
@@ -2630,7 +2630,7 @@ ONNX_OPERATOR_SET_SCHEMA(
         .SetDoc(LayerNormalization_ver17_doc)
         .Attr(
             "axis",
-            "The first normalization dimension. If rank(X) is r, axis' allowed range is [-r, r]. "
+            "The first normalization dimension. If rank(X) is r, axis' allowed range is [-r, r). "
             "Negative value means counting dimensions from the back.",
             AttributeProto::INT,
             static_cast<int64_t>(-1))