-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin urllib3 (remove upper bound) to allow 2.x version to be used #265
base: mainline
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
-r requirements.txt | ||
pillow | ||
numpy | ||
pytest | ||
dataclasses | ||
requests_mock | ||
tenacity |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,4 @@ | ||
# marqo client: | ||
urllib3<2.0.0, >=1.26.0 | ||
urllib3>=1.26.0 | ||
requests | ||
packaging | ||
|
||
# testing | ||
pillow | ||
numpy | ||
pytest | ||
dataclasses | ||
pydantic>=2.0.0 | ||
requests_mock | ||
tenacity | ||
packaging |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,13 +8,11 @@ | |
install_requires=[ | ||
# client: | ||
"requests", | ||
"urllib3<2.0.0, >=1.26.0", | ||
"urllib3>=1.26.0", | ||
"pydantic>=2.0.0", | ||
"typing-extensions>=4.5.0", | ||
"packaging" | ||
], | ||
tests_require=[ | ||
"pytest", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pytest is installed by tox. Since we use tox to run tests, this section in setup.py is not used any more. |
||
"tox" | ||
], | ||
name="marqo", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you want to upgrade the version here to publish it to Pypi? |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this dep is only introduced to use @deprecated annotation. Since we do not need this dep now, I removed this restraint.