Unpin urllib3 (remove upper bound) to allow 2.x version to be used #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papa99do
commented
Nov 22, 2024
| "pydantic>=2.0.0", | ||
| "typing-extensions>=4.5.0", |
There was a problem hiding this comment.
this dep is only introduced to use @deprecated annotation. Since we do not need this dep now, I removed this restraint.
papa99do
commented
Nov 22, 2024
| "packaging" | ||
| ], | ||
| tests_require=[ | ||
| "pytest", |
There was a problem hiding this comment.
pytest is installed by tox. Since we use tox to run tests, this section in setup.py is not used any more.
wanliAlex
requested changes
Nov 25, 2024
| "packaging" | ||
| ], | ||
| tests_require=[ | ||
| "pytest", | ||
| "tox" | ||
| ], | ||
| name="marqo", |
There was a problem hiding this comment.
Do you want to upgrade the version here to publish it to Pypi?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Dependency versioning
What is the current behavior? (You can also link to an open issue here)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: