vbdec patch to fix broken download #632
Conversation
Update VBDEC to preferred version 2.22.2023
Update version information
Retriggering CI/CD because it used old URLs, not sure why.
|
I have no idea how this is pulling the old github path in CI testing. |
|
That is weird indeed. @Ana06, any idea what's going on here? |
Trigger CI/CD again to see if earlier issue was cache related.
|
Somehow this still tries to install the old version: https://github.com/mandiant/VM-Packages/actions/runs/5885235123/job/15961387073?pr=632#step:4:35 |
packages/vbdec.vm/vbdec.vm.nuspec
Outdated
| <authors>vbGamer45, David Zimmer</authors> | ||
| <description>VBDec is a VB6 disassembler and PCode debugger</description> | ||
| <description>VBDec works as a VB6 disassembler and PCode debugger.</description> |
There was a problem hiding this comment.
also a structure viewer for all vb6 executables and can generate IDA scripts to integrate structures and named function offsets (native and pcode)
There was a problem hiding this comment.
Thanks for the input @dzzie, but as mentioned in our documentation, we want to keep the description as short as possible and not to modify it with version updates:
The description should be short and not include version specific details or other information that is likely to change in a future version.
The description is a nuspec required field, that's why we include, but we are not really using it (as these packages are mostly installed by a installer and are not in the chocolatey community feed). So we would like to save maintaince work.
Update per author
packages/vbdec.vm/vbdec.vm.nuspec
Outdated
| @@ -2,9 +2,9 @@ | |||
| <package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd"> | |||
| <metadata> | |||
| <id>vbdec.vm</id> | |||
| <version>12.7.22</version> | |||
| <version>2.22.23</version> | |||
There was a problem hiding this comment.
The previous version is 12.7.22 (higher). When updating a package you should always increase the version, as when you install the package the highest available version is installed. That is why the tests are still testing the version before the fix.
I see that the version of this tool is VBDec v1.0.917 - compiled: 2.22.23:
I suspect that the version we had before is also not the tool version, but the compilation date. We should use the tool version:
| <version>2.22.23</version> | |
| <version>1.0.917</version> |
But this version would be also lower than the current one. As the current package is broken, I propose we delete it manually from myget. @mr-tz is that fine for you?
There was a problem hiding this comment.
Ah, great catch! Yes, that's fine by me.
There was a problem hiding this comment.
@tylerwhardy can you update the version to 1.0.917?
There was a problem hiding this comment.
I have deleted the package in myget and re-trigger the CI and tests are working now. 😄 thanks @tylerwhardy!
I am going to merge the PR with squash and merge in order to keep a clean commit history.
Resolves #618 by updating download path to newly provided URL.